Use std:: types instead of custom integers #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They are supposed to be the same but it's more C++ friendly.
robUx4
added
api-break
mbunkus
approved these changes
Oct 15, 2022
There was a problem hiding this comment.
LGTM. Also gave it a try together with Matroska-Org/libmatroska#86; works well (needed a one-line change in MKVToolNix as it still included libebml_t.h, which I've changed to EbmlTypes.h).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref. #111, Deprecates #86
For now the I/O API are unchanged as they should have their own PR for API changes.
filepos_tfor example might move in the IOCallbacks class.libmatroska needs to be updated as it includes specifically
libebml_t.h