KaxSemantic.h: add enum values from the specs with documentation #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This provides some useful source for anyone parsing Matroska files. The enum names are the same as in libmatroska2 (mkclean/mkvalidator). The documentation doesn't look great but it still gives useful inline information.
Merged
|
The names could be adapted to match existing names in mkvtoolnix to make things easier. |
mbunkus
approved these changes
Sep 17, 2022
There was a problem hiding this comment.
This is fine. Tested with MKVToolNix; no problems.
I assume that the list of constants is auto-generated from the specs, and that I don't have to verify their names & values match the specs — right?
Edit: right, I now see that your original comment states that it was indeed auto-generated. Great!
|
Yes, I'm also going to add it to libmatroska2 as well with the same names. I checked mkvtoolnix and you don't have enums for these values yet, so no need to try pre-existing names. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides some useful source for anyone parsing Matroska files. The enum names are the same as in libmatroska2 (mkclean/mkvalidator).
The documentation doesn't look great but it still gives useful inline information.
This should not break ABI. The names/types will need to be kept stable in the future.
Generated with Matroska-Org/foundation-source#91