Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Travis and AppVeyor CI #6

Closed
wants to merge 4 commits into from
Closed

Enable Travis and AppVeyor CI #6

wants to merge 4 commits into from

Conversation

r9y9
Copy link

@r9y9 r9y9 commented Jan 18, 2018

This PR fixes a windows compilation issue (r9y9@677f5df) and enables travis and appveyor for windows/linux CI. While I noticed the tests were failing locally, the PR doesn't address the issue and I would like to focus on setting up infrastructure first.

I added badges for travis and appveyor to README. This URLs should be modified before or after merging.

Fixes #3

@r9y9
Copy link
Author

r9y9 commented Jan 22, 2018

Hi, @MattShannon, Could you take a look?

@r9y9
Copy link
Author

r9y9 commented Feb 5, 2018

bump

@MattShannon
Copy link
Owner

Ryuichi, thank you so much for helping get bandmat building in windows! That was incredibly helpful. As I mentioned in a previous comment, I actually use darcs and git is just a convenient wrapper so I can host on github, so I decided not to pull this PR as is, but as you can see I cribbed heavily from it.

Hope this helps close some of those downstream issues, and a thousand apologies that it took me so long to address this!

@MattShannon MattShannon closed this Jun 5, 2018
@r9y9 r9y9 deleted the ci branch June 5, 2018 12:44
@r9y9
Copy link
Author

r9y9 commented Jun 5, 2018

@MattShannon Thank you very much for your response. I'm guessing you are working on fixing some problems now. If it's done, would you mind creating a new release?

@MattShannon
Copy link
Owner

Yep, bandmat 0.7 contains all the recent fixes. Tests are all green, though there's one test that's flakier than I'd like specifically on python3 64-bit windows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with installation
2 participants