Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Job cancellation #80

Merged
merged 2 commits into from
Dec 12, 2019
Merged

Job cancellation #80

merged 2 commits into from
Dec 12, 2019

Conversation

eileen-kuehn
Copy link
Member

Job cancellation from drones sometimes did not properly result in the expected state. When the drone tried to cancel a job it could happen that the success state of a drone was not properly set to False as the job had not been properly started before. This PR includes a fix for this issue.

@codecov
Copy link

codecov bot commented Dec 12, 2019

Codecov Report

Merging #80 into master will decrease coverage by 0.31%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #80      +/-   ##
==========================================
- Coverage   60.21%   59.89%   -0.32%     
==========================================
  Files          15       15              
  Lines         759      763       +4     
  Branches      111      111              
==========================================
  Hits          457      457              
- Misses        278      282       +4     
  Partials       24       24
Impacted Files Coverage Δ
lapis/drone.py 74.5% <0%> (-3.05%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a74d181...92989aa. Read the comment docs.

Copy link
Member

@maxfischer2781 maxfischer2781 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. If you feel that job.cancel should be async (so you do not need the second await instant), please request/push it to usim.

@eileen-kuehn eileen-kuehn merged commit 989b805 into master Dec 12, 2019
@eileen-kuehn eileen-kuehn deleted the fix/job-cancelation branch December 12, 2019 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants