Make forecast caching match observation caching #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #200 +/- ##
==========================================
+ Coverage 93.40% 93.67% +0.26%
==========================================
Files 9 9
Lines 622 632 +10
==========================================
+ Hits 581 592 +11
+ Misses 41 40 -1 ☔ View full report in Codecov by Sentry. |
|
Not updating cache would be expected in use with |
|
Looks okay to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Downside of this approach is that it adds some calculations to the forecast in addition to checking for filtered forecasts. This will duplicate calculations. Future enhancement would have a separate method for filtering and additions.Code refactored to filter forecast for old forecasts separately from making additions.