Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing invalid keyword test #48

Open
Matthewar opened this issue Jul 8, 2018 · 2 comments
Open

Failing invalid keyword test #48

Matthewar opened this issue Jul 8, 2018 · 2 comments
Assignees
@Matthewar
Labels
bug

Comments

@Matthewar
Copy link
Owner

See build #4
Input: "OF\241\ENQ"
@Matthewar Matthewar added the bug label Jul 8, 2018
@Matthewar
Copy link
Owner Author

Had a similar problem for a different keyword (IN) for input: "IN\213w\EOT <80o"

@Matthewar Matthewar self-assigned this Jul 8, 2018
@Matthewar
Copy link
Owner Author

Seems that '\241' and '\213' both register as alphanumeric characters although they are not ASCII, so while the parser accepts that the keyword is followed by a non-alphanumeric character, the generation scheme thinks that it should fail.
Since VHDL only accepts certain characters should consider limiting input type to parser: #49

Matthewar added a commit that referenced this issue Jul 8, 2018
@Matthewar
Fix for issue #48.
f8981ec 
Use of unicode characters causing issues with what the parser accepts as
an alphanumeric character and what the Haskell function "isAlphaNum"
returns.
See issue #49 for potential improvement to parser.
Fixed bug by changing random generator to check for alphanumeric
characters in a different way.
Closes #48.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Matthewar Matthewar

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Matthewar