Upgrade dependencies #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Matthias247
reviewed
Sep 14, 2020
Cargo.toml
Outdated
| futures-core = { version = "0.3.0", default-features = false } | ||
| lock_api = "0.3.2" | ||
| parking_lot = { version = "0.10", optional = true } | ||
| futures-core = { version = "0.3.5", default-features = false } |
There was a problem hiding this comment.
Given this doesn't really use a lot from futures maybe it should stay with the old version or just use ^0.3. Reduces the chances for dependendy conflicts.
Cargo.toml
Outdated
| futures = { version = "0.3.5", default-features = true, features = ["async-await"] } | ||
| futures-test = { version = "0.3.5", default-features = true } | ||
| pin-utils = "0.1.0" | ||
| criterion = "0.3.3" |
There was a problem hiding this comment.
This, crossbeam, and rand should be pushed to the newest version with the same minor number anyway. Don't see a lot of benefit in tracking fix versions.
No concern regarding more explicit updates of async-std and tokio however, since there seem to have been quite a bit of changes.
|
I just ran cargo upgrade without thinking. The only upgrades I care about is: |
jean-airoldie
force-pushed
the
bump_deps
branch
from
c9f328a
to
21f2829
Compare
Matthias247
reviewed
Sep 14, 2020
Co-authored-by: Matthias Einwag <matthias.einwag@live.com>
Matthias247
approved these changes
Sep 14, 2020
|
How about a release for this, and other recent merges? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.