Skip to content
This repository has been archived by the owner on Apr 23, 2020. It is now read-only.

Replace deprecated __defineGetter__ and __defineSetter__ syntaxes. #107

Merged
merged 0 commits into from
Dec 25, 2013

Conversation

Ndpnt
Copy link
Collaborator

@Ndpnt Ndpnt commented Dec 19, 2013

See #64

target.emit('access', key);
return hook.toSeleniumElement(hook);
},
set: inputHandler
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably add a TODO: remove for v0.7, since the = syntax has been deprecated for a while.

@MattiSG
Copy link
Owner

MattiSG commented Dec 23, 2013

Thank you very much. I can handle the minor amendments on this PR if you want. Let me know!

@Ndpnt
Copy link
Collaborator Author

Ndpnt commented Dec 23, 2013

I will not have the time to do it this week, so you can handle the amendments ;).

@MattiSG MattiSG merged commit f7fbf12 into v0.6.2 Dec 25, 2013
@MattiSG MattiSG deleted the remove-deprecated-define-getter-setter branch December 25, 2013 21:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants