Make ReadableStream properly implement AsyncIterable
#142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MattiasBuelens
force-pushed
the
fix-async-iterator
branch
from
0e964f0
to
b1cdb56
Compare
|
Thank you! |
|
@MattiasBuelens from the release on the main page here, it doesn't look like this made it to prod yet - would you be able to ship a new 3.3.3 release? |
|
@jacoblee93 Woops, I thought I already made a release for this. Sorry! Version 3.3.3 is now up. 🚀 |
|
Ah let's go! Thank you 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ReadableStreamclass from the polyfill didn't exactly match theAsyncIterable<R>type from TypeScript. This caused type errors for downstream users.Also, if
Symbol.asyncIteratordoesn't exist, we now try to useSymbol.for("Symbol.asyncIterator")instead to match core-js 3, or fall back to the string"@@asyncIterator"as a last resort.Fixes #141.