Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add typings #19

Merged
merged 1 commit into from
Oct 4, 2017
Merged

Add typings #19

merged 1 commit into from
Oct 4, 2017

Conversation

bilby91
Copy link
Contributor

@bilby91 bilby91 commented Oct 3, 2017

Fixes #10

@bilby91
Copy link
Contributor Author

bilby91 commented Oct 3, 2017

Let me know if you want to remove the lock file.

@MauriceButler
Copy link
Owner

👍 Thanks for this.

I am happy for the lock file to be there.

This looks like a good start, but from my limited TS knowledge does this also need to allow for the optional arguments to the constructor?

I think it would need to be something like this

constructor(options: BunyanLoggly.IOptions, bufferLength? : number, bufferTimeout?: number, logglyCallback?: Function);

But I honestly dont know what I am doing in TS so happy for you to correct me.

@bilby91
Copy link
Contributor Author

bilby91 commented Oct 4, 2017

You are right! Will fix that soon. Thanks!

@bilby91
Copy link
Contributor Author

bilby91 commented Oct 4, 2017

@MauriceButler Done!

@MauriceButler MauriceButler merged commit 6afe390 into MauriceButler:master Oct 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bilby91 @MauriceButler