-
-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cleaned up multi-service compose #75
Conversation
|
everything should be address from: #75 (comment) |
@reeseovine can you test this and confirm jt works as expected? 🙏 |
Does the server still need to be up before the client can build? I'm getting this error on the client which doesn't seem related:
|
Wait, I'm dumb lol. I was on the wrong branch. But now I get this error when building the server:
|
Sorry for the spam... It's been a while. I've run into that issue before and just needed to add ...buuuuuut now we're back to the first issue:
|
No, the server isn't required to be running anymore for the client -- it was too difficult to figure out the docker setup. And that import error is my fault, I was rushing. You should be able to just remove that line; I'll push a fix soon. |
Ok cool, it works now! Even got it up on my server behind nginx proxy manager. |
branch should be up to date now. |
👏 LGTM |
this is carryover from: #13
gets the images built and containers running for both server and client. there is a server build issue in
builder
because it cant find.env
:explicitly giving the image a duplicated
.env.test
->.env
allows the build to complete and create container. there is another issue that i ran into when loading the client athttp://localhost:3001/
:and when navigating to:
http://localhost:3001/signup
viewing the server health at:
http://localhost:3000/health