Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide challenge environment file #6

Merged
merged 6 commits into from
Mar 14, 2024
Merged

Provide challenge environment file #6

merged 6 commits into from
Mar 14, 2024

Conversation

IlyaOrson
Copy link
Collaborator

Noticed these were missing from a fresh environment.

@MaximilianB2
Copy link
Owner

Hi Ilya,

These packages are not required by pc-gym to run and hence were removed to allow for a faster installation.

@IlyaOrson
Copy link
Collaborator Author

Makes sense. The example notebook does not run without them though. We could add them as optional dependencies maybe or leave them in the condo environment file just for the setup of the challenge and examples.

@josetorraca
Copy link
Collaborator

So Ilya, I was able to run the tests without them, except for sb3. Because, of course, you need some kind of library for the RL training part.
But honestly, I don't see why we need jupyterlab, torch, and mkdocs.
I had this conversation with Max last Friday, I think it would be better to do your suggestion of adding these libraries as an extra-installation.

@IlyaOrson
Copy link
Collaborator Author

IlyaOrson commented Mar 11, 2024

Sounds good to me. Shall we add them as optional dependencies and in environment files then?

@IlyaOrson IlyaOrson changed the title Add missing dependencies Provide challenge environment file Mar 11, 2024
@IlyaOrson
Copy link
Collaborator Author

Environments to run the example notebooks or challenge

mamba env create -f environment.yml

pixi init --import environment.yml

Used the identifier "optional"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants