Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cache version value to the journal #46

Closed
Tracked by #47
MSDarwish2000 opened this issue Feb 17, 2023 · 0 comments · Fixed by #69
Closed
Tracked by #47

Add cache version value to the journal #46

MSDarwish2000 opened this issue Feb 17, 2023 · 0 comments · Fixed by #69
Labels
enhancement New feature or request FileKache
Milestone

Comments

@MSDarwish2000
Copy link
Member

Is your feature request related to a problem? Please describe.
When the application changes the way it is generating the cached values, or transforming the keys, it will be required to clear the cache and starts a new one.

Describe the solution you'd like
Adding a cache version parameter to the journaled cache and writing it to the journal header will help the library to track these changes and clear the cache directory if the version is changed than the passed one.

Describe alternatives you've considered
Leaving this to application developers to handle but it is easier to handle internally.

Additional context
This behavior is already seen in Jake Wharton's DiskLruCache for example.

@MSDarwish2000 MSDarwish2000 added enhancement New feature or request FileKache labels Feb 17, 2023
@MSDarwish2000 MSDarwish2000 mentioned this issue Feb 17, 2023
4 tasks
@MSDarwish2000 MSDarwish2000 added this to the Kache v2.0.0 milestone Feb 18, 2023
@MSDarwish2000 MSDarwish2000 linked a pull request Apr 15, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request FileKache
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant