Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support Korean #35

Merged
merged 1 commit into from
Nov 25, 2023
Merged

Conversation

donghoon-song
Copy link
Contributor

No description provided.

Copy link

vercel bot commented Nov 8, 2023

Someone is attempting to deploy a commit to a Personal Account owned by @Mayandev on Vercel.

@Mayandev first needs to authorize it.

@donghoon-song
Copy link
Contributor Author

I have one suggestion. According to Korean, the order of words are different from other languages. So it is better to edit the AvatarPicker component as below. But I think it is too specific to Korean now. So I want to listen to your opinion.

 const {
    t,
    i18n: { language },
  } = useTranslation('common');

<h1 className="py-4 w-full">
    {language === 'ko'
        ? `${t(`${avatarPart.part}`)} ${t('Choose')}`
        : `${t('Choose')} ${t(`${avatarPart.part}`)}`}
</h1>

Copy link

vercel bot commented Nov 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
notion-avatar ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 21, 2023 9:08am

@Mayandev
Copy link
Owner

I have one suggestion. According to Korean, the order of words are different from other languages. So it is better to edit the AvatarPicker component as below. But I think it is too specific to Korean now. So I want to listen to your opinion.

 const {
    t,
    i18n: { language },
  } = useTranslation('common');

<h1 className="py-4 w-full">
    {language === 'ko'
        ? `${t(`${avatarPart.part}`)} ${t('Choose')}`
        : `${t('Choose')} ${t(`${avatarPart.part}`)}`}
</h1>

Big thx for your contribution. And nice catch! I prefer to use the interpolation feature for i18nNext. Anyway, let get it to merged first 🙏

@donghoon-song
Copy link
Contributor Author

Oh thank you. Let me check the interpolation feature and use.

@Mayandev Mayandev merged commit db7a84c into Mayandev:main Nov 25, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants