Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added LocalNetworkAccessAccountsDisk function and general cleanup #14

Merged
merged 14 commits into from
Nov 16, 2022

Conversation

subat0mik
Copy link
Collaborator

@subat0mik subat0mik commented Oct 19, 2022

Pull Requests

Requirements

Please fill out the template below. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.

For more details, please see https://github.com/Mayyhem/SharpSCCM/blob/main/CONTRIBUTING.md#pull-requests.

Description

Added LocalNetworkAccessAccountsDisk function (ported from this PR from @guervild for SharpDPAPI: GhostPack/SharpDPAPI#17), general cleanup and exception handling in Credentials.cs and Dpapi.cs

Fixes # (issue)
#13

Type of change

Please delete options that are not relevant.

  • [X ] New feature (non-breaking change which adds functionality)

Testing

Tested both local naa wmi and local naa disk commands with expected results

Release Notes

Added local naa disk command that will parse current and historical NAA blobs from the CIM repository file.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@guervild
Copy link

guervild commented Nov 7, 2022

Thanks for the mention, I appreciate it (here is my twitter if you prefer that (link)

Quick question.. Is your talk on SCCM on youtube ? 😅

@subat0mik
Copy link
Collaborator Author

Thanks for the mention, I appreciate it (here is my twitter if you prefer that (link)

Quick question.. Is your talk on SCCM on youtube ? 😅

It is not on YouTube. We presented at Arsenal/DemoLabs which were not recorded.

@Mayyhem Mayyhem merged commit e4ffb02 into Mayyhem:main Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants