Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport 2.1: Add missing return value check in ECDSA test suite #2110

Merged
merged 1 commit into from
Oct 29, 2018
Merged

Backport 2.1: Add missing return value check in ECDSA test suite #2110

merged 1 commit into from
Oct 29, 2018

Conversation

hanno-becker
Copy link

This is the backport to Mbed TLS 2.1 of #2107.

Add missing return value check in ECDSA test suite
a966e6f 
The test case `ecdsa_det_test_vectors` from the ECDSA test suite
called `mbedtls_md()` without checking its return value.
@hanno-becker hanno-becker added bug mbed TLS team needs-review Every commit must be reviewed by at least two team members, component-tls labels Oct 17, 2018
@simonbutcher
Copy link
Contributor

retest

@simonbutcher simonbutcher added needs-ci Needs to pass CI tests and removed needs-review Every commit must be reviewed by at least two team members, labels Oct 25, 2018
@simonbutcher
Copy link
Contributor

Jenkins fails only with the test script tests/scripts/doxygen.sh which has been independently fixed with PR #2011. That's as good as a pass.

@simonbutcher simonbutcher added approved Design and code approved - may be waiting for CI or backports and removed needs-ci Needs to pass CI tests labels Oct 26, 2018
@simonbutcher simonbutcher merged commit a966e6f into Mbed-TLS:mbedtls-2.1 Oct 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k-stachowiak k-stachowiak k-stachowiak approved these changes

@AndrzejKurek AndrzejKurek AndrzejKurek approved these changes

Assignees
No one assigned
Labels
approved Design and code approved - may be waiting for CI or backports bug component-tls
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hanno-becker @simonbutcher @k-stachowiak @AndrzejKurek