Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating packages & recipes #123

Merged
merged 13 commits into from
Oct 25, 2023
Merged

Conversation

melroy89
Copy link
Member

@melroy89 melroy89 commented Oct 25, 2023

This PR is mainly focusing on the remaining package updates and recipe updates.

It updates all symfony/* packages. And I ran recipe updates for:

  • symfony/framework-bundle
  • symfony/web-profiler-bundle
  • symfony/validator
  • phpstan/phpstan
  • symfony/messenger.

As well as fixing the indentation of the config yaml files (to 4 spaces), so future recipes will (hopefully) merge easier.

@melroy89 melroy89 requested a review from a user October 25, 2023 01:56
@melroy89
Copy link
Member Author

After this PR I focus again on actual error pollution and deprecation messages. Since now most packages are up to date.

@ghost ghost added dependencies Pull requests that update a dependency file backend Backend related issues and pull requests labels Oct 25, 2023
@ghost
Copy link

ghost commented Oct 25, 2023

After this PR I focus again on actual error pollution and deprecation messages. Since now most packages are up to date.

I'll let this run for a couple hours, but I don't see any issues so far.

@melroy89
Copy link
Member Author

Indeed. This time I didn't dare to touch the doctrine recipe yet haha. But also test it on my instance and testing boost and voting /favor

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues observed during testing, looks good!

@melroy89
Copy link
Member Author

U sure this time? 😄 Thanks!

@ghost
Copy link

ghost commented Oct 25, 2023

kbin.run hasn't fallen over yet, so I think you're good to go.

@melroy89 melroy89 merged commit d8b4867 into main Oct 25, 2023
5 checks passed
@melroy89 melroy89 deleted the improve_error_warning_log_pollution_4 branch October 25, 2023 15:08
asdfzdfj added a commit to asdfzdfj/mbin that referenced this pull request May 22, 2024
adjust tag parsing in TagExtractor to filter out hashtag that only
consists of only numbers e.g. MbinOrg#123

the markdown parsing is also adjusted in a similar way to not create a
TagLink node when it consists of only numbers
asdfzdfj added a commit to asdfzdfj/mbin that referenced this pull request Jul 27, 2024
adjust tag parsing in TagExtractor to filter out hashtag that only
consists of only numbers e.g. MbinOrg#123

the markdown parsing is also adjusted in a similar way to not create a
TagLink node when it consists of only numbers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Backend related issues and pull requests dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant