Do not automatically subscribe admin OR users to new federated magazine lookups

[ghost]

Disables the default /kbin behavior of automatically subscribing the admin to federated magazine lookups. The searching user must explicitly hit the subscribe button in order for the Mbin instance to pull in federated updates.

This change would also seem to remove the need for the admin panel option to explicitly allow only logged in users to search for federated content since you have to be logged in to subscribe anyway, but I left it intact incase we want to modify this behavior in the future.

[e-five256]

Super curious how this flow looks now (especially with the described async annoyance in that:) user searches for new remote mag, gets no results because the process is async, searches again, and... does it show up and load that time? but doesn't subscribe them, so they have to click into that mag and subscribe

At the point before any subscribers, the magazine exists as a new entry in magazine, but without any subscribers it won't get activity events?

Edit: we walked through the flow together in matrix and all I can say is the UX continues to remain confusing as heck, which it always has been even before this PR 😆 but everything seemed fine, I think the risk is low, as debounced has already lived with the flow of manually unsubscribing so we know how that acts, there are more improvements to come in benti's remote mod rework

[BentiGorlich]

Does this work when you are creating a new magazine? I did try it in my PR, but reverted it, because newly created local magazines would always throw a 500 because the owner was missing

[ghost]

I added an condition where local mag creations still get auto subscribed to the user, now this will only impact federated magazines. :-)

[melroy89]

Thank god.