Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for the Privacy Portal OAUTH provider #818

Merged
2 commits merged into from
Jun 12, 2024

Conversation

privacyguard
Copy link
Contributor

@privacyguard privacyguard commented Jun 12, 2024

This PR adds support for SSO with Privacy Portal.

Related Issue: #792

OAUTH Provider: https://privacyportal.org

Mbin Configuration:
OAUTH_PRIVACYPORTAL_ID=<CLIENT_ID obtained from https://app.privacyportal.org >
OAUTH_PRIVACYPORTAL_SECRET=<CLIENT_SECRET obtained from https://app.privacyportal.org >

Provider Specific Information:

  • Emails provided are Privacy Aliases which means there can never be a match with existing user emails in the DB
  • Privacy Portal uses Passwordless Authentication

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll need to update:

mbin/src/Entity/User.php

Lines 762 to 765 in 9b207e2

public function isSsoControlled(): bool
{
return $this->oauthAzureId || $this->oauthGithubId || $this->oauthGoogleId || $this->oauthFacebookId || $this->oauthKeycloakId || $this->oauthSimpleLoginId || $this->oauthZitadelId || $this->oauthAuthentikId;
}

to include Privacy Portal

@ghost ghost added enhancement New feature or request backend Backend related issues and pull requests sso Single-sign-on issues or pull requests labels Jun 12, 2024
@privacyguard
Copy link
Contributor Author

@nobodyatroot Thanks for catching this!

@privacyguard privacyguard requested a review from a user June 12, 2024 22:44
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghost ghost merged commit c153d62 into MbinOrg:main Jun 12, 2024
7 checks passed
@privacyguard
Copy link
Contributor Author

@nobodyatroot Thanks for the quick review!

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Backend related issues and pull requests enhancement New feature or request sso Single-sign-on issues or pull requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant