Define OSX bundle properties #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
McMartin
force-pushed
the
define-OSX-bundle-properties
branch
from
717cdc2
to
be5e1a4
Compare
|
They are quite different. I've attached them for faster review. Noticeable differences are JUCECmake:
All other "BUNDLE" properties are equivalent. |
McMartin
force-pushed
the
define-OSX-bundle-properties
branch
8 times, most recently
from
18ef54b
to
0d58d5d
Compare
McMartin
force-pushed
the
define-OSX-bundle-properties
branch
from
0d58d5d
to
90acbce
Compare
|
@MartyLake: I reworked the last commit, please have another look, thanks! |
|
LGTM! all comments and commit message are clear, and the concision with which you implemented this feature is amazing :-)👌 |
This was referenced Jan 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@MartyLake: please build the
AudioAppExampleorHelloWorldexample with bothProjucerandJUCE.cmaketo check that the final.plistfiles are similar. Please review as well, thanks!