-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support the "Binary location" configuration setting #237
Merged
McMartin
merged 6 commits into
master
from
support-Binary-location-configuration-setting
Aug 23, 2017
Merged
Support the "Binary location" configuration setting #237
McMartin
merged 6 commits into
master
from
support-Binary-location-configuration-setting
Aug 23, 2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
McMartin
force-pushed
the
support-Binary-location-configuration-setting
branch
from
August 22, 2017 17:15
59752ce
to
007e738
Compare
McMartin
force-pushed
the
support-Binary-location-configuration-setting
branch
2 times, most recently
from
August 22, 2017 17:20
ea5b743
to
42b149d
Compare
MartyLake
approved these changes
Aug 23, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
McMartin
force-pushed
the
support-Binary-location-configuration-setting
branch
from
August 23, 2017 08:30
42b149d
to
f647eda
Compare
We frequently write $<CONFIG:${configuration_name}> to make a setting active only when the current configuration is ${configuration_name}. Writing $<CONFIG:${config}> is as understandable and shorter, thus easier to parse.
In three commits we will set the LIBRARY_OUTPUT_DIRECTORY and RUNTIME_OUTPUT_DIRECTORY properties in order to support the "Binary location" configuration setting of Projucer. Moreover using install() means that we now get some nice output to inform us that the plugin is being installed: -- Installing: ~/Library/Audio/Plug-Ins/VST/foo.component -- Installing: ~/Library/Audio/Plug-Ins/VST/foo.component/Contents -- Installing: ~/Library/Audio/Plug-Ins/VST/foo.component/Contents/Info.plist -- Installing: ~/Library/Audio/Plug-Ins/VST/foo.component/Contents/MacOS -- Installing: ~/Library/Audio/Plug-Ins/VST/foo.component/Contents/MacOS/foo -- Installing: ~/Library/Audio/Plug-Ins/VST/foo.component/Contents/PkgInfo
Make it easier to support plugins that should be installed elsewhere than under ~/Library/Audio/Plug-Ins, for instance on Windows.
McMartin
force-pushed
the
support-Binary-location-configuration-setting
branch
from
August 23, 2017 08:35
f647eda
to
fe48afb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #127
Changes what was done in #190
@MartyLake: please review, thanks!