Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support the "Binary location" configuration setting #237

Merged
merged 6 commits into from
Aug 23, 2017

Conversation

McMartin
Copy link
Owner

Resolves #127
Changes what was done in #190

@MartyLake: please review, thanks!

@McMartin McMartin force-pushed the support-Binary-location-configuration-setting branch from 59752ce to 007e738 Compare August 22, 2017 17:15
@McMartin
Copy link
Owner Author

McMartin commented Aug 22, 2017

@WGuLL: since you were interested in #190, I think you should try and review this PR, especially as it adds install components that could conflict with existing installation steps.

@McMartin McMartin force-pushed the support-Binary-location-configuration-setting branch 2 times, most recently from ea5b743 to 42b149d Compare August 22, 2017 17:20
Copy link
Collaborator

@MartyLake MartyLake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@McMartin McMartin force-pushed the support-Binary-location-configuration-setting branch from 42b149d to f647eda Compare August 23, 2017 08:30
We frequently write $<CONFIG:${configuration_name}> to make a setting active
only when the current configuration is ${configuration_name}. Writing
$<CONFIG:${config}> is as understandable and shorter, thus easier to parse.
In three commits we will set the LIBRARY_OUTPUT_DIRECTORY and
RUNTIME_OUTPUT_DIRECTORY properties in order to support the "Binary location"
configuration setting of Projucer.

Moreover using install() means that we now get some nice output to inform us
that the plugin is being installed:

-- Installing: ~/Library/Audio/Plug-Ins/VST/foo.component
-- Installing: ~/Library/Audio/Plug-Ins/VST/foo.component/Contents
-- Installing: ~/Library/Audio/Plug-Ins/VST/foo.component/Contents/Info.plist
-- Installing: ~/Library/Audio/Plug-Ins/VST/foo.component/Contents/MacOS
-- Installing: ~/Library/Audio/Plug-Ins/VST/foo.component/Contents/MacOS/foo
-- Installing: ~/Library/Audio/Plug-Ins/VST/foo.component/Contents/PkgInfo
Make it easier to support plugins that should be installed elsewhere than under
~/Library/Audio/Plug-Ins, for instance on Windows.
@McMartin McMartin force-pushed the support-Binary-location-configuration-setting branch from f647eda to fe48afb Compare August 23, 2017 08:35
@McMartin McMartin merged commit b68ccda into master Aug 23, 2017
@McMartin McMartin deleted the support-Binary-location-configuration-setting branch August 23, 2017 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants