Respect the terms of the GNU General Public License #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BinaryDataBuilder uses files from JUCE that are licensed under the terms of the GNU General Public License, so it must be licensed under the same terms.
Reprojucer.cmake and the CMakeLists.txt files for the JUCE examples and extras are not directly using JUCE, so they don't have to be licensed under the terms of the GNU General Public License. However, it is easier to deal with only one license in JUCE.cmake, so let's unify and use GPLv3 for whole of JUCE.cmake.
|
LGTM. I agree with the change of license for the files I authored ! |
|
Do we have to copyright every source file ? Or just the repository ? |
|
I think we have to keep it this way: https://www.gnu.org/licenses/gpl-faq.html#NoticeInSourceFile |
|
According to https://github.com/McMartin/JUCE.cmake/blob/97ce486c4159c283c223b13f15c854d374b5797f/LICENSE#L629, it is better to do so. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@MartyLake: please review and confirm that you agree with the change of license for the files that you authored, thanks!