Create ci.yaml #91
Merged
Create ci.yaml #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
This reverts commit 8f7ea21.
camdnnn
approved these changes
Apr 1, 2024
|
I love lint |
JAWalmsley
reviewed
Apr 1, 2024
There was a problem hiding this comment.
Is it an issue that the linter is linting our svgs? Might not matter but probably not hard to ignore them either
There was a problem hiding this comment.
Not sure that it is, I cleaned this up myself because I tried importing it using the same standard as everything else (ECMAScript vs CommonJS / Import vs Require) and with import having different rules, I had to remove some properties.
There was a problem hiding this comment.
React itself was tossing build errors on this matter
There was a problem hiding this comment.
Linter only enforced the usage of ECMAScript vs CommonJS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.