Add some tweaks to improve transformation time #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ichttt
added a commit
to ichttt/MinecraftForge
that referenced
this pull request
Feb 19, 2019
|
Sadly, I disagree with how this is implemented. I get your feedback, and I'll definitely look at ways to improve the transformation time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some additional checks so the classwriter is not used if possible, as classwriting with computing frames can take some time, and avoiding creating a new arraylist if no transformers are present.
Nearly cuts the time spend on transforming classes in half with some changes to forge to return a null ClassNode when nothing is transformed (About 1.5 seconds total to 2.8 spend on ClassTransformer#transform).