This repository has been archived by the owner on Nov 21, 2020. It is now read-only.
Merging 'new-eff' to 'master' #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
McSinyx
suggested changes
Mar 20, 2020
McSinyx
suggested changes
Mar 20, 2020
McSinyx
suggested changes
Mar 21, 2020
McSinyx
reviewed
Mar 21, 2020
McSinyx
force-pushed
the
new-eff
branch
2 times, most recently
from
25fb346
to
9ff81b5
Compare
Huy-Ngo
suggested changes
Mar 22, 2020
src/palace.pyx
Outdated
| @@ -1671,7 +1670,14 @@ cdef class AuxiliaryEffectSlot: | |||
| """ | |||
| self.impl.set_send_auto(value) | |||
|
|
|||
| # TODO: apply effect | |||
| @setter | |||
| def effect(self, effect: Effect) -> None: | |||
There was a problem hiding this comment.
To be consistent with our code the argument for @setter methods is value.
There was a problem hiding this comment.
Don't forget to change the function's content too.
McSinyx
approved these changes
Mar 22, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.