Skip to content
This repository has been archived by the owner on Nov 21, 2020. It is now read-only.

Expose OpenAL-defined reverb efx #62

Closed
McSinyx opened this issue Mar 29, 2020 · 8 comments
Closed

Expose OpenAL-defined reverb efx #62

McSinyx opened this issue Mar 29, 2020 · 8 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@McSinyx
Copy link
Owner

McSinyx commented Mar 29, 2020

This issue is a follow-up of GH-24 (and thus GH-58).

Per private is discussion, we discovered that Effect is intended to load pre-defined effects, hence the unusual size of the parameter that the class' methods take, or at least that's true for reverb effects, which are defined in efx-presets.h by OpenAL (which is copied to alure for convenience purposes).

@9a24f0, if you want, you can take up this issue, otherwise I can do it myself. The task is simply declare the reverbs and adjust the Effect's method to take simpler input.

@McSinyx McSinyx added this to the 0.1 milestone Mar 29, 2020
@9a24f0 9a24f0 self-assigned this Mar 29, 2020
@9a24f0
Copy link
Collaborator

9a24f0 commented Mar 29, 2020

I'm wondering that whether Reverb and EAXReverb are different things. In Effect I did implemented EAXReverb, what should I do now?

@McSinyx
Copy link
Owner Author

McSinyx commented Mar 29, 2020

@9a24f0: oops, sorry it's in efx-presets.h. I've just edited the original statement too.

@9a24f0
Copy link
Collaborator

9a24f0 commented Mar 29, 2020

I'm even more confused rn...

@McSinyx
Copy link
Owner Author

McSinyx commented Mar 29, 2020

The user should be able to use, e.g. EFX_REVERB_PRESET_GENERIC as their reverb configuration. Is it clear to you now?

@9a24f0
Copy link
Collaborator

9a24f0 commented Mar 29, 2020

Not yet...
We even have reverb configuration implemented?

@McSinyx
Copy link
Owner Author

McSinyx commented Mar 29, 2020

It's the Effect.reverb_properties thing. BTW notice the odd docstring of the other property (sorry didn't catch that during revision).

@9a24f0
Copy link
Collaborator

9a24f0 commented Mar 29, 2020

Which docstring? I've read through docstrings in Effect and don't see anything strange to me...
Also, Idk how to start, may I have an example on how to expose EFX_REVERB_PRESET_GENERIC

@McSinyx
Copy link
Owner Author

McSinyx commented Mar 30, 2020

Which docstring? I've read through docstrings in Effect and don't see anything strange to me...

You have to be kidding me: Effect.chorus_properties

Also, Idk how to start, may I have an example on how to expose EFX_REVERB_PRESET_GENERIC

At this point, I think I need to clarify that I'm not your mentor, but your collaborator. You can't keep the mindset of awaiting me to tell you how to do something---you have all the resources in your hands, do research, experiment, try this try that, etc.

EFXEAXREVERBPROPERTIES is a struct, and the pre-defined presets are memories. All you have to do is cdef extern them like other preprocessor values, but I'm taking over this since it might takes too much time. Please focus on testing then.

@McSinyx McSinyx assigned McSinyx and unassigned 9a24f0 Mar 30, 2020
@McSinyx McSinyx added the enhancement New feature or request label Apr 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants