Remember previous context

[Huy-Ngo]

I try to resolve #30 by saving context into a static stack-list current_context (maybe I should rename it to current_contexts) in which the top (last) item is the current context. When a context is destroyed (__exit__), it's popped and the latest previous context will be loaded into use_context.

[McSinyx]

As part of this PR, could you please also expose alure::Context::{Make,Get}ThreadCurrent, as part of use_context and (for-you-to-be-defined) current_context through a thread parameter or something (be creative on the name).

[McSinyx]

Please also see comments on #30.

[McSinyx]

Mostly LGTM now, just a few adjustments in tests and API needed.

[McSinyx]

I've just take a look at Travis build log and turns out it failed because alure::Context::GetCurrent is not exposed (in src/alure.pxd). BTW when you're done with this, please rebase all commits into two:

• The test
• The fix

in any order you find suitable. There are bunch of tutorials for interactive git rebase online.

[Huy-Ngo]

There is this error I don't know why happens:

================================================================================= ERRORS =================================================================================
__________________________________________________________________ ERROR at teardown of test_gain_auto ___________________________________________________________________

    @fixture(scope='session')
    def device():
        """Provide the default device."""
>       with Device() as dev: yield dev

tests/conftest.py:32: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
src/palace.pyx:175: in palace.Device.__exit__
    self.close()
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

>   self.impl.close()
E   RuntimeError: Trying to close device with contexts

src/palace.pyx:329: RuntimeError

I suspect this has something to do with my edit of __enter__ and __exit__ of Context class. (Edit: I think it has something to do with get_current() not returning None: as I mentioned here, I am not sure if it will return a null pointer or not)

Also I don't understand why these 11 non-context tests failed even after I pulling from master. (Edit: nvm it failed on master too, this merge failed due to the error mentioned above).

[McSinyx]

I think it's pretty clear why:

RuntimeError: Trying to close device with contexts

It's likely that there're contexts left undestroyed (I'm looking at the current_context function where Context(dev) is called then impl is replaced by another, but the older one isn't killed properly).

Also I don't understand why these 11 non-context tests failed

pytest with fixtures is very fragile when the fixtures get fucked, and since all tests uses the device fixture, it's normal that they failed.

even after I pulling from master.

I hope you meant after checking out master, then try to delete the compiled bytecodes in tests. There should be a way to disable these annoying caches, but I couldn't find that yet.

[Huy-Ngo]

Just looked through the builds above and it started failing here.

[McSinyx]

Just looked through the builds above and it started failing here.

I don't think it's relevant, since we've changed the approach. Please try the suggested changes.

[Huy-Ngo]

Yay it passes the test. Is there any other change request before rebasing?

[McSinyx]

Generally this looks good to me, aside a few tiny details.

Note on documentation, the explanation of context manager needs update after the change (that's why current_context is required in the first place, there's no way to describe what the with thing does without the function).

Just in case the comment requesting rebase get lost, split the patch into two commits: one for the change and one for the test, in any order. Cheers.

[Huy-Ngo]

Hmm... I wish I always made different commits for separate files. Is that okay if I leave some commit changing tests/test_context.py to be in the same one as src/palace.pyx because splitting it up is troublesome?

Aight, I think I need some practice first.

[McSinyx]

There's no point of calling alure.Context.get_current() twice. As defined in alure2.h, bool of alure::Context is the nonnullity, thus all you have to do is just if not current: return None. Also in the line below use __new__ to create the empty device, just for consistency (ugh why isn't @9a24f0 done with #38?). Remember to fixup the changes (git rebase -i HEAD~2).

After this, use the Rebase and merge button on Github to merge the changes. Then on branch master pump the version (in setup.cfg, to 0.0.10 I think, you can do it as part of the fixup) draft a new pre-release with sdist (./setup.py sdist) attached, wait for the wheels to get pushed to PyPI by Travis, then install it using pip. Switch to gh-pages branch, update the version (in src/conf.py), generate the new documentation and push. That's all the work for a new release lmao.

And don't forget to document how the context returned by current_context have the wrong message handler in a new issue (pseudo test: with context: assert current_context().message_handler is context.message_handler).

[McSinyx]

Test passed, feel free to Rebase and merge when you're ready.