Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update fight_component.js #2

Merged
merged 2 commits into from
Sep 23, 2020
Merged

Update fight_component.js #2

merged 2 commits into from
Sep 23, 2020

Conversation

zarmstrong
Copy link
Contributor

Added a 10 xp above buffer, to account for edge cases. This matches the encounter ratings found in The Slithering. Have not checked against other Paizo encounters

@zarmstrong
Update fight_component.js
121f9d4 
Added a 10 xp above buffer, to account for edge cases. This matches the encounter ratings found in The Slithering.  Have not checked against other Paizo encounters
@zarmstrong
Copy link
Contributor Author

#1 this should fix the issue I raised

@zarmstrong
modified: build/pf2_encounter_planner.js
efadea0 
	modified:   build/pf2_encounter_planner.min.js
@zarmstrong
Copy link
Contributor Author

zarmstrong commented Sep 10, 2020 •
edited
Loading

i found another encounter that doesn't match paizo, even with these changes. cancelling this merge request
Ignore that. The book is incorrect in this case, the book creates an encounter that should be rated as Low but seems to be misprinted as Moderate. Reopening pull request.

@zarmstrong zarmstrong closed this Sep 10, 2020
@zarmstrong zarmstrong reopened this Sep 10, 2020
@Mcgode Mcgode merged commit c3b50ca into Mcgode:master Sep 23, 2020
@Mcgode Mcgode mentioned this pull request Sep 23, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zarmstrong @Mcgode