Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix opening file from URI #482

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

joshas
Copy link
Contributor

@joshas joshas commented Oct 15, 2020

My attempt to fix #419 . Only tested with FTP provider and local provider. Also tested with file names containing spaces on FTP - no problems with opening them.

@MeanEYE
Copy link
Owner

MeanEYE commented Oct 16, 2020

Am not sure this will work with all the cases.

@joshas
Copy link
Contributor Author

joshas commented Oct 16, 2020

I presume there are only two types of paths: local (ones without ://, like /usr/local/bin/) and URI (ftp://, smb://, etc).
What other cases should I try to test? I'll try to set up connections to real protocols and test with them. Any corner cases that I should be aware of, e.g. illegal symbols, spaces in file names?

@MeanEYE
Copy link
Owner

MeanEYE commented Oct 17, 2020

Unicode characters, symbols, etc. Without encode path I feel it might fail but do test and let me know. I could very well be wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't execute (open) files if provider is URI based
2 participants