Skip to content
This repository has been archived by the owner on Jun 28, 2024. It is now read-only.

API measure loading fix (in cqm-parsers) #1283

Merged
merged 2 commits into from
Jul 22, 2019

Conversation

hossenlopp
Copy link
Contributor

@hossenlopp hossenlopp commented Jul 19, 2019

Pull requests into Bonnie require the following. Submitter and reviewer should ✅ when done. For items that are not-applicable, note it's not-applicable ("N/A") and ✅.

BEFORE MERGE

Submitter:

Reviewer 1:

Name: @mayerm94

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
  • The tests appropriately test the new code, including edge cases
  • You have tried to break the code

Reviewer 2:

Name: @LOsborne

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
  • The tests appropriately test the new code, including edge cases
  • You have tried to break the code

@MeasureAuthoringTool MeasureAuthoringTool deleted a comment from codecov bot Jul 22, 2019
@MeasureAuthoringTool MeasureAuthoringTool deleted a comment from codecov bot Jul 22, 2019
@lukoktonos lukoktonos requested review from lukoktonos and removed request for jbradl11 July 22, 2019 12:48
Copy link
Contributor

@lukoktonos lukoktonos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SHA is right and uploads work both from the client and regular bonnie

@jbradl11 jbradl11 merged commit 0d1cce4 into 2019-standards-update Jul 22, 2019
@jbradl11 jbradl11 deleted the 2019-standards-update-api-loading-fix branch July 22, 2019 12:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants