Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add copy & paste to context menu and enable context menu in per file view #158

Merged
merged 4 commits into from
Jul 20, 2020

Conversation

g-maxime
Copy link
Contributor

@g-maxime g-maxime commented Jul 4, 2020

Fixes #133

Signed-off-by: Maxime Gervais <gervais.maxime@gmail.com>
Signed-off-by: Maxime Gervais <gervais.maxime@gmail.com>
Signed-off-by: Maxime Gervais <gervais.maxime@gmail.com>
@dericed
Copy link
Collaborator

dericed commented Jul 9, 2020

Can you add keyboard shortcuts to this? In my first try I was trying Command-C and Control-V but it didn't work, but the right click context menu's "Copy/Paste" did.

@dericed
Copy link
Collaborator

dericed commented Jul 19, 2020

Hi @g-maxime, this is better, but the interface doesn't seem to update after I paste.
Currently, I can select a field, Command-C, select a field of the same column but different file, Command-V. Then there is no update in the GUI; however if I select another field or interact with the gui somehow then the pasted value appears, so there's a refresh missing directly after the paste. If I use "Paste" from the right-click menu, then the pasted value appears right away.

Signed-off-by: Maxime Gervais <gervais.maxime@gmail.com>
Copy link
Collaborator

@dericed dericed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JeromeMartinez JeromeMartinez merged commit 9800c3b into MediaArea:master Jul 20, 2020
@g-maxime g-maxime deleted the copy-paste branch December 29, 2022 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Users cannot copy-paste between fields
3 participants