-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(actions): adjust workflow triggers #379
Conversation
Add the `pull_request_target` trigger, so that pull requests from a fork will also start a build. Otherwise they can't be verified. A downside to this is that changes to the CI workflow can't be directly verified on a pull request anymore without some workarounds, because the CI will now run in the context of the base of the pull request. Closes #378. See also: - https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#pull_request_target
⚠ Vulnerability Report Please consider this as a tentative appraisal, consult Dependency-Track for reliable results.
|
@heubeck or maybe it's better to have a separate workflow, which will "just" do maven test and docker build/verify for PRs from forks? |
could also make sense to split the workflow into pieces and pick and choose which ones should run where |
Which parts of the workflow would you skip for fork-based runs? |
Add the
pull_request_target
trigger, so that pull requests from afork will also start a build. Otherwise they can't be verified.
A downside to this is that changes to the CI workflow can't be directly
verified on a pull request anymore without some workarounds, because
the CI will now run in the context of the base of the pull request.
Closes #378.
See also: