Fix compiler crash and profitability test in memset optimisation #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djtodoro
reviewed
Jul 25, 2023
added 2 commits
July 31, 2023 23:36
Targets with unaligned accesses can make a better job of inlining memsets without knowing exact alignment.
cme
changed the title
djtodoro
reviewed
Aug 2, 2023
| @@ -297,7 +297,7 @@ void MemsetRanges::addRange(int64_t Start, int64_t Size, Value *Ptr, | |||
| I->Start = Start; | |||
| I->StartPtr = Ptr; | |||
| I->Alignment = Alignment; | |||
| if (I->MaxAlignmentOffset != 0) | |||
| if (I->MaxAlignment != 0) | |||
There was a problem hiding this comment.
Thanks. This now makes sense.
|
This makes sense to me. But, the new heuristics [0] introduced couple of other failures as well that still fail: [0] efeed9e |
|
@cme what is the status of this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The legacy
getDestAlignmentmember used to get alignment for existingmemsetintrinsics can use a value of 0 to represent undefined alignment, which will cause the alignment offset calculation to fail as it uses this as the denominator of a modulo operation.