Implement ConditionBuilder as a recursive evaluation engine. #108
Conversation
|
note this depends on #107 |
nicks
force-pushed
the
nicks/conditions
branch
from
41374fc
to
3b58e40
Compare
|
ping? |
|
cc @kellyellis @kylewm this is the attribute-filter PR that i told you about yesterday, it basically copies Hopper's approach of having a struct representing the filter. |
|
👀 |
lib/ConditionBuilder.js
Outdated
|
|
||
| /** | ||
| * @param {Object=} opt_conditions | ||
| * @param {Object=} opt_exprs |
There was a problem hiding this comment.
Might help to document a little about what this Object looks like
There was a problem hiding this comment.
ya, agreed. improved the docs in a couple places. also i just removed this argument, because i think it's probably more confusing than useful.
lib/ConditionBuilder.js
Outdated
| * @param {Array.<ConditionBuilder|ConditionJunction>} conditions | ||
| * @return {ConditionJunction} | ||
| * Creates a new Conditional expression with an operator (AND, EQ, etc) | ||
| */ |
There was a problem hiding this comment.
I realize they aren't required here, but @param JSDoc would make these functions easier to understand
There was a problem hiding this comment.
good point. i defined some better types for these that will hopefully make it clearer and more constrained.
This doesn't change the existing API. This just clears the way to support arbitrarily complex DynamoDB expressions.
nicks
force-pushed
the
nicks/conditions
branch
from
3b58e40
to
f75c123
Compare
Hello @andrew3886, @xiao,
Please review the following commits I made in branch 'nicks/conditions'.
41374fc (2017-01-17 20:24:26 -0500)
Implement ConditionBuilder as a recursive evaluation engine.
This doesn't change the existing API. This just clears
the way to support arbitrarily complex DynamoDB expressions.
7993582 (2017-01-17 17:24:46 -0500)
Move Dynamite over to the new UpdateExpression API
R=@andrew3886
R=@xiao