Properly handle attribute names with underscores #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicks
force-pushed
the
nicks/attributename
branch
2 times, most recently
from
b73443a
to
193f777
Compare
kylewm
approved these changes
Feb 8, 2017
nicks
force-pushed
the
nicks/attributename
branch
from
193f777
to
d63dd9c
Compare
kylewm
reviewed
Feb 8, 2017
lib/typeUtil.js
Outdated
| // If this is just a reserved word, use # + word | ||
| if (VALID_ATTR_RE.test(key)) { | ||
| return '#' + key | ||
| } |
There was a problem hiding this comment.
maybe split this into isReservedWord, isValidAttributeName, getReservedWordAlias, getInvalidNameAlias?
There was a problem hiding this comment.
oh i like that idea better, done
nicks
force-pushed
the
nicks/attributename
branch
from
d63dd9c
to
3debebc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @kellyellis, @kylewm,
Please review the following commits I made in branch 'nicks/attributename'.
ca5d2a0 (2017-02-08 14:49:47 -0500)
Properly handle attribute names with underscores
R=@kellyellis
R=@kylewm