Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow GSIs that share the same hash key as the main table and sort GSI query results in FakeDynamo #58

Merged
merged 1 commit into from
Feb 18, 2015

Conversation

xiao
Copy link
Contributor

@xiao xiao commented Feb 18, 2015

Hello @kylehg, @nicks,

Please review the following commits I made in branch 'xiao-gsi-fake'.

a573ac9 (2015-02-18 11:14:48 -0800)
Allow GSIs that share the same hash key as the main table and sort GSI query results in FakeDynamo

R=@kylehg
R=@nicks

Code Review Checklist:

  • Pull Request has appropriate QA Notes
  • Commits are adequately tested
  • Code is easy to understand and conforms to our style guides
  • Incomplete code, if applicable, is marked with TODOs
  • Logging and metrics are suitable

@nicks
Copy link
Contributor

nicks commented Feb 18, 2015

lg

xiao added a commit that referenced this pull request Feb 18, 2015
Allow GSIs that share the same hash key as the main table and sort GSI query results in FakeDynamo
@xiao xiao merged commit 5b251f7 into master Feb 18, 2015
@kylehg kylehg deleted the xiao-gsi-fake branch February 18, 2015 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants