-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to use local-dynamo, start local-dynamo from setUp #65
Conversation
Now that we have local-dynamo and the test code runs on it's own, it would be nice to see if we could set up travis-ci integration for the repo. |
* no conditions. | ||
* @return {DynamoRequest} | ||
*/ | ||
DynamoRequest.prototype.setQueryFilter = function (conditions) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
conditions
-> filters
?
First pass done. A high-level question -- can we consolidate |
|
I still think we should consolidate them in this PR, so we don't introduce a new API ( Here is a proposal that I think would work. Let me know what you think about it.
|
a9499a9
to
0570ee0
Compare
0570ee0
to
daaafac
Compare
Alright @xiao, changes have been made. PTAL. |
f6181f4
to
f69b70c
Compare
f69b70c
to
6771b6e
Compare
LGTM! Beautiful piece. |
Update to use local-dynamo, start local-dynamo from setUp
Hello @xiao,
Please review the following commits I made in branch 'nathan-AttributeValueList'.
a9499a9 (2015-07-23 17:04:42 -0700)
Update to use local-dynamo, start local-dynamo from setUp
7b973b5 (2015-07-23 16:37:35 -0700)
Migrate all uses of AttribueValueList/ComparisonOperator to ConditionBuilder
R=@xiao
Test plan: 'New unit test, old unit tests'