Reduce cardinality of dynamo error messages #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not bumping the version yet, @adrianlee44 is making more changes to dynamite and will bump then. |
| } | ||
| util.inherits(ConditionalError, Error) | ||
| ConditionalError.prototype.type = 'ConditionalError' |
There was a problem hiding this comment.
This might be used. I would suggest creating a new name property.
shitijagarwal
force-pushed
the
shitij-errors-take2
branch
from
0c9d837
to
2e52259
Compare
|
lgtm |
shitijagarwal
pushed a commit
that referenced
this pull request
Mar 2, 2016
Reduce cardinality of dynamo error messages
|
LG! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @sboora, @adrianlee44,
Please review the following commits I made in branch 'shitij-errors-take2'.
0c9d837 (2016-03-02 14:56:12 -0800)
Reduce cardinality of dynamo error messages
R=@sboora
R=@adrianlee44