Add an api for giving local-dynamo more heap #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh nice, I didn't know you could do this — I suspect this could've saved us a good bit of trouble before |
| * An options object: | ||
| * port: {number} - The port to run on. Required. | ||
| * dir: {?string=} - The location of database files. Optional Will run in-memory if null. | ||
| * heap: {?string=} - The amount of heap space, e.g., 512m. If not specified, uses JVM defaults. |
There was a problem hiding this comment.
Maybe link to something indicating more info about the format of this option, e.g., http://stackoverflow.com/questions/5374455/what-does-java-option-xmx-stand-for
|
LGTM! |
|
more docs added! |
nicks
added a commit
that referenced
this pull request
Jun 22, 2015
Add an api for giving local-dynamo more heap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @kylehg, @chaosgame,
Please review the following commits I made in branch 'nick-api'.
61beeba (2015-06-22 15:04:14 -0700)
Add an api for giving local-dynamo more heap
R=@kylehg
R=@chaosgame
Test plan: 'not tested'