Feature/esafe 298 add rsa signing to cryppo #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zbarbuto
requested changes
Nov 1, 2019
| const signature = key.sign(mdDigest); | ||
| return { | ||
| signature: signature, | ||
| data: data |
There was a problem hiding this comment.
@GenteiJanken
return {
signature,
data
| const signed = decomposedPayload[0] | ||
| const signingStrategy = decomposedPayload[1] | ||
| const encodedSignature = decomposedPayload[2] | ||
| const encodedData = decomposedPayload[3] |
There was a problem hiding this comment.
Use array destructuring for these.
There was a problem hiding this comment.
[signed, signingStrategy, encodedSignature, encodedData] = decomposedPayload
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is intended to mirror changes to the Ruby Cryppo gem, providing a facility to sign and verify messages with an RSA keypair, as well as serialize a signature and corresponding data for transport to the keystore microservice.