New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow encrypt decrypt directly using encryption artifacts #20

Merged

zbarbuto merged 2 commits into master from task/allow-direct-encrypt-decrypt

Aug 12, 2020

Contributor

vijayshiyani commented Aug 12, 2020

No description provided.


          allow encrypt decrypt directly using encryption artifacts

51e2827

vijayshiyani requested a review from zbarbuto

August 12, 2020 04:48

Contributor

zbarbuto commented Aug 12, 2020 •

edited

Loading

Since those two methods are no longer private & internal can we rename them -

Remove the underscore which is hinting them as private
Give them a more complete name to describe what they do encryptWithKeyUsingArtefacts / decryptWithKeyUsingArtefacts`


          rename methods to have meaningfull name

0a14238

zbarbuto merged commit de3f081 into master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet