Fix/unbreak changes #37
Conversation
| encodingVersion?: EncodingVersions; | ||
| }): Promise<Uint8Array | null> { | ||
| const phrase = key || passphrase; |
There was a problem hiding this comment.
we only need to _deriveKeyWithOptions, if its passphrase,
if it's already a key , then all we need is EncryptionKey class object out of it and don't need to _deriveKeyWithOptions
https://github.com/Meeco/cryppo-js/blob/610f14507c2ea58916eff8212b85277f52b6f17a/src/encryption-key.ts
|
My opinion is if 2.0.1 included breaking changes by mistake then revert and release as 2.0.2 then release those breaking changes as actual breaking changes (3.0.0) The fix that was in the original 2.0.1 can then be applied and rolled out as a 2.0.3 and 3.0.1 |
|
Ok here's what I'll do:
Branch develop will have the unreleased changes, Branch master will have the latest released changes and release 2.0.2 will have the (unbreaking as intended) changes from the fix |
|
I approve that approach 👍 |
Release 2.0.1 sucked in unreleased breaking changes that were sitting in master.
This massages the breaking changes to be backwards compatible, hence release version 2.1.0.
Alternately we could just git revert the breaking commit and release 2.0.2 to fix the bad 2.0.1 release