Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Technical] Upgrade Services to Spring #132

Open
boubaker opened this issue May 5, 2024 · 8 comments
Open

[Technical] Upgrade Services to Spring #132

boubaker opened this issue May 5, 2024 · 8 comments

Comments

@boubaker
Copy link
Member

boubaker commented May 5, 2024

Rationale

After Spring Integration MIP #57, the Service layer isn't completely which makes the usage isn't exclusively made by new technologies in new development. We will need the act the effective upgrade to Spring in Service layer in order to enforce the new development Best practice.

1. Functional Requirements

No functional changes has to be made.

2. Technical Requirements

Expected Volume & Performance

N/A

Security

Allow to access Spring REST using Basic authentication.

Extensibility

All Meeds REST endpoints has to be accessible using associated Web Archive of each extension.

Configurability

N/A

Upgradability

N/A

Existing Features

N/A

Feature Flags

N/A

4. Software Architecture

Security

Allow to access Spring REST using Basic authentication.

Access

All Meeds REST endpoints has to be accessible using associated Web Archive of each extension.

Services & processing

N/A

Data and persistence

N/A

@boubaker
Copy link
Member Author

boubaker commented May 5, 2024

Ready for tech review by Meeds DAO members ( eXo: @rdenarie )

@rdenarie
Copy link
Member

rdenarie commented May 6, 2024

About the security part, and the Basic Authentication, is it possible to make it "activable" ?

In some context, we need this authentication, but in other, for security reason, we need to close this door, and not expose endpoint with basic auth, because for example, we use a sso context like SAML or other, and we dont want that user access to rest endpoint with 'internal' exo account.

So for me, some features are needed :

  • Possibility to activate/deactivate the BASIC authent - MUST
  • Possibitity to restric users who can access to this basic authentication, by listing them OR by generating and API token. - SHOULD

I speak about this point because you mentionned it in the security part, BUT, we have to discuss if this concern is part of this mip or not.

@boubaker
Copy link
Member Author

boubaker commented May 6, 2024

The idea is to keep the same features as now without changes.
We can consider enablement or restriction features in MIPs apart.

Thus to not combine multiple concerns in one, which may lead to an excessive cost to this first outcome, both suggestions can be considered apart (same as API tokens which I suggested multiple times before, but not prioritized yet. Besides we will need this for Gamification Module interoperability)

@rdenarie
Copy link
Member

rdenarie commented May 6, 2024

Ok, no problem.

I came to this reflexion when viewing the security part, and after writing requirements, I remark that it was not the center of the MIP, so no pb to consider it in another MIP.
Ok for me

@boubaker
Copy link
Member Author

boubaker commented May 6, 2024

Thanks for the feedback, Go-func added as well since no functional changes required on this.

boubaker added a commit to Meeds-io/app-center that referenced this issue May 13, 2024
This change will upgrade services to use spring instead of Kernel & WS.
boubaker added a commit to Meeds-io/task that referenced this issue May 13, 2024
…-io/MIPs#132

Prior to this change, App Center Data was injected at startup time using XML file. This change will introduce AppCenter applications using JSON format.
boubaker added a commit to Meeds-io/wallet that referenced this issue May 13, 2024
…-io/MIPs#132

Prior to this change, App Center Data was injected at startup time using XML file. This change will introduce AppCenter applications using JSON format.
boubaker added a commit to Meeds-io/perk-store that referenced this issue May 13, 2024
…-io/MIPs#132

Prior to this change, App Center Data was injected at startup time using XML file. This change will introduce AppCenter applications using JSON format.
boubaker added a commit to Meeds-io/analytics that referenced this issue May 13, 2024
…-io/MIPs#132

Prior to this change, App Center Data was injected at startup time using XML file. This change will introduce AppCenter applications using JSON format.
boubaker added a commit to Meeds-io/gamification that referenced this issue May 13, 2024
…-io/MIPs#132

Prior to this change, App Center Data was injected at startup time using XML file. This change will introduce AppCenter applications using JSON format.
boubaker added a commit to Meeds-io/gatein-portal that referenced this issue May 13, 2024
Prior to this change, Portal database changelogs are processed late in the startup using PortalCotnainer. This change makes sure to initialize the database using RootContainer to make sure that the Database initialization is made before any other service startup.
boubaker added a commit to Meeds-io/gatein-portal that referenced this issue May 13, 2024
Prior to this change, Portal database changelogs are processed late in the startup using PortalCotnainer. This change makes sure to initialize the database using RootContainer to make sure that the Database initialization is made before any other service startup.
boubaker added a commit to Meeds-io/app-center that referenced this issue May 13, 2024
This change will upgrade services to use spring instead of Kernel & WS.
boubaker added a commit to Meeds-io/app-center that referenced this issue May 13, 2024
This change will upgrade services to use spring instead of Kernel & WS.
boubaker added a commit to Meeds-io/app-center that referenced this issue May 13, 2024
This change will upgrade services to use spring instead of Kernel & WS.
exo-swf pushed a commit to Meeds-io/gamification that referenced this issue May 14, 2024
…-io/MIPs#132

Prior to this change, App Center Data was injected at startup time using XML file. This change will introduce AppCenter applications using JSON format.
boubaker added a commit to Meeds-io/content that referenced this issue May 14, 2024
…-io/MIPs#132

Prior to this change, App Center Data was injected at startup time using XML file. This change will introduce AppCenter applications using JSON format.
boubaker added a commit to Meeds-io/task that referenced this issue May 14, 2024
…-io/MIPs#132

Prior to this change, App Center Data was injected at startup time using XML file. This change will introduce AppCenter applications using JSON format.
boubaker added a commit to Meeds-io/wallet that referenced this issue May 14, 2024
…-io/MIPs#132

Prior to this change, App Center Data was injected at startup time using XML file. This change will introduce AppCenter applications using JSON format.
boubaker added a commit to Meeds-io/perk-store that referenced this issue May 14, 2024
…-io/MIPs#132

Prior to this change, App Center Data was injected at startup time using XML file. This change will introduce AppCenter applications using JSON format.
boubaker added a commit to Meeds-io/analytics that referenced this issue May 14, 2024
…-io/MIPs#132

Prior to this change, App Center Data was injected at startup time using XML file. This change will introduce AppCenter applications using JSON format.
exo-swf pushed a commit to Meeds-io/gamification that referenced this issue May 17, 2024
…-io/MIPs#132

Prior to this change, App Center Data was injected at startup time using XML file. This change will introduce AppCenter applications using JSON format.
boubaker added a commit to Meeds-io/app-center that referenced this issue May 17, 2024
This change will upgrade services to use spring instead of Kernel & WS.
@boubaker
Copy link
Member Author

Merged to develop for kudos & app-center

exo-swf pushed a commit to Meeds-io/analytics that referenced this issue Jun 18, 2024
…-io/MIPs#132 (#194)

Prior to this change, App Center Data was injected at startup time using
XML file. This change will introduce AppCenter applications using JSON
format.
exo-swf pushed a commit to Meeds-io/kudos that referenced this issue Jun 18, 2024
This proceed to migrate all Kudos API to use Spring DI instead of
Kernel.
exo-swf pushed a commit to Meeds-io/perk-store that referenced this issue Jun 18, 2024
…-io/MIPs#132 (#328)

Prior to this change, App Center Data was injected at startup time using XML file. This change will introduce AppCenter applications using JSON format.
exo-swf pushed a commit to Meeds-io/wallet that referenced this issue Jun 18, 2024
…-io/MIPs#132 (#522)

Prior to this change, App Center Data was injected at startup time using
XML file. This change will introduce AppCenter applications using JSON
format.
exo-swf pushed a commit to Meeds-io/wallet that referenced this issue Jun 18, 2024
exo-swf pushed a commit to Meeds-io/app-center that referenced this issue Jun 18, 2024
This change will upgrade services to use spring instead of Kernel & WS.
exo-swf pushed a commit to Meeds-io/task that referenced this issue Jun 18, 2024
…-io/MIPs#132 (#394)

Prior to this change, App Center Data was injected at startup time using
XML file. This change will introduce AppCenter applications using JSON
format.
rdenarie pushed a commit to Meeds-io/content that referenced this issue Jun 18, 2024
…-io/MIPs#132 (#132)

Prior to this change, App Center Data was injected at startup time using XML file. This change will introduce AppCenter applications using JSON format.
rdenarie added a commit to exo-addons/time-tracker that referenced this issue Jun 18, 2024
rdenarie pushed a commit to Meeds-io/gamification that referenced this issue Jun 19, 2024
…-io/MIPs#132 (#1619)

Prior to this change, App Center Data was injected at startup time using
XML file. This change will introduce AppCenter applications using JSON
format.
boubaker pushed a commit to Meeds-io/gamification-twitter that referenced this issue Jul 3, 2024
This change will upgrade services to use spring instead of Kernel & WS.
exo-swf pushed a commit to Meeds-io/gamification-twitter that referenced this issue Jul 5, 2024
This change will upgrade services to use spring instead of Kernel & WS.
boubaker pushed a commit to Meeds-io/gamification-twitter that referenced this issue Jul 9, 2024
This change will upgrade services to use spring instead of Kernel & WS.
AzmiTouil added a commit to Meeds-io/gamification-github that referenced this issue Jul 11, 2024
This change will upgrade services to use spring instead of Kernel & WS.
boubaker pushed a commit to Meeds-io/gamification-twitter that referenced this issue Jul 12, 2024
This change will upgrade services to use spring instead of Kernel & WS.
AzmiTouil added a commit to Meeds-io/gamification-github that referenced this issue Jul 18, 2024
This change will upgrade services to use spring instead of Kernel & WS.
AzmiTouil added a commit to Meeds-io/gamification-github that referenced this issue Jul 18, 2024
This change will upgrade services to use spring instead of Kernel & WS.
AzmiTouil added a commit to Meeds-io/gamification-github that referenced this issue Jul 18, 2024
This change will upgrade services to use spring instead of Kernel & WS.
AzmiTouil added a commit to Meeds-io/gamification-github that referenced this issue Jul 18, 2024
This change will upgrade services to use spring instead of Kernel & WS.
AzmiTouil added a commit to Meeds-io/gamification-github that referenced this issue Jul 22, 2024
This change will upgrade services to use spring instead of Kernel & WS.
boubaker pushed a commit to Meeds-io/gamification-github that referenced this issue Aug 14, 2024
This change will upgrade services to use spring instead of Kernel & WS.
exo-swf pushed a commit to Meeds-io/gamification-twitter that referenced this issue Aug 14, 2024
This change will upgrade services to use spring instead of Kernel & WS.
AzmiTouil added a commit to Meeds-io/gamification-github that referenced this issue Aug 16, 2024
This change will upgrade services to use spring instead of Kernel & WS.
AzmiTouil added a commit to Meeds-io/gamification-twitter that referenced this issue Aug 16, 2024
This change will upgrade services to use spring instead of Kernel & WS.
AzmiTouil added a commit to Meeds-io/gamification-twitter that referenced this issue Aug 16, 2024
This change will upgrade services to use spring instead of Kernel & WS.
AzmiTouil added a commit to Meeds-io/gamification-github that referenced this issue Aug 16, 2024
This change will upgrade services to use spring instead of Kernel & WS.
exo-swf pushed a commit to Meeds-io/gamification-github that referenced this issue Aug 16, 2024
This change will upgrade services to use spring instead of Kernel & WS.
exo-swf pushed a commit to Meeds-io/gamification-twitter that referenced this issue Aug 16, 2024
This change will upgrade services to use spring instead of Kernel & WS.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Accepted
Development

No branches or pull requests

2 participants