Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Selected Row does not change when Rapid Editing #5398

Closed
mtbayley opened this issue Mar 22, 2024 · 5 comments · Fixed by #5420
Closed

[Bug]: Selected Row does not change when Rapid Editing #5398

mtbayley opened this issue Mar 22, 2024 · 5 comments · Fixed by #5420
Assignees
Labels
Type: Bug 🐞 Something isn't working
Milestone

Comments

@mtbayley
Copy link
Contributor

Blazorise Version

1.5.0

What Blazorise provider are you running on?

Bootstrap5

Link to minimal reproduction or a simple code snippet

https://blazorise.com/docs/extensions/datagrid/features/editing

Steps to reproduce

  1. Select a row using the # column
  2. Attempt to edit another cell by clicking on it

image

What is expected?

The selected row should change to the edited row if the row is selectable

What is actually happening?

The row selected does not change

What browsers do you see the problem on?

Microsoft Edge

Any additional comments?

Sorry, I've submitted a lot of issues this week!

This may no longer be an issue if navigation and editing is separated as discussed in #5383. I wanted to bring this to your attention to consider.

@mtbayley mtbayley added the Type: Bug 🐞 Something isn't working label Mar 22, 2024
@David-Moreira
Copy link
Contributor

Hello,

I'm not understanding how to reproduce,

  1. https://blazorise.com/docs/extensions/datagrid/features/editing
  2. First Grid, change to EditMode.Cell
  3. Click Wilkinson Cell
  4. Click the cell with the number 3, it will be selected but not editable, as the cell is not marked as editable
  5. Click any other cell?

When I get to 5, when I click any other cell it is editable as expected?

@mtbayley
Copy link
Contributor Author

mtbayley commented Mar 22, 2024

I'm looking at the selected row (the row that is highlighted). Editing is working as expected.
The only way to select it is to click on a cell that is not editable (# in this case).

Also, when I'm editing a cell in the selected row, I can't see which row I have selected.

Perhaps this gif adds more context
msedge_nq2vSEPEYb

@David-Moreira
Copy link
Contributor

Hmm I see, so your point is that cell clicks aren't triggering row selection, this kind of is by design.
If you use the command column to trigger a row edit, same thing happens, the row is in edit mode even though it's not selected.

Now the thing here, is that you are explicitly clicking on something inside the row, so it's argueable whether it should select the row or not.
But the thing is that this is "cell mode", so imagining that we do trigger RowClick & Selection Changed here, does it really make sense?

The DataGrid always worked like this where the row being edited does not show the "selection look".

@stsrki any opinion on this?

@stsrki
Copy link
Collaborator

stsrki commented Mar 23, 2024

I think selecting the row by the last focused cell makes the most sense. Be it in read or edit mode.

@David-Moreira
Copy link
Contributor

David-Moreira commented Mar 26, 2024

In that case let's treat this as a bug indeed. It will be fixed in v1.5.
(The part where focusing the cell, selects the row)


The part about not noticing a cell is selected when the row is on edit mode has always been like that as far as I know. Although you can argue it's a bug, it's been like that for so long, at least as long as I remember, that I would not change it in a patch, but would consider it in a separate issue and making sure it doesn't interfere with how the user is able to edit the row, and make it part of a release instead.

@David-Moreira David-Moreira added this to the 1.5 support milestone Mar 26, 2024
@David-Moreira David-Moreira self-assigned this Mar 26, 2024
@stsrki stsrki closed this as completed Mar 27, 2024
@stsrki stsrki added this to Support Aug 3, 2024
@stsrki stsrki moved this to ✔ Done in Support Aug 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug 🐞 Something isn't working
Projects
Archived in project
3 participants