Hover widget: Markdown renderer - combine MarkdownRendererOptions wit… #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h SanitizerConfig
pkudryashov
approved these changes
Oct 19, 2021
koranser
approved these changes
Oct 20, 2021
Ulop
deleted the
combined_markdown_renderer_options_with_sanitizer_config
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Расширил
MarkdownRendererOptionsследующими полями:headingBlockRenderer- для возможности переопределить, как будет рисоваться тегh[1-6]. Будет использоваться для "дорисовки" к имени функции, к которой выведен тултип, кнопки открытия справкиonClickHandler?: (content: string, event?: IMouseEvent) => boolean- для обработки нажатия на вышеуказанную кнопку, при возвращенииfalse, будет выполняться логика стандартного обработчикаsanitizerConfigSanitizerConfigиMarkdownRendererOptionsдля предотвращения дублирования кода. Если бы оба объекта передавались отдельными методами, то во всех затронутых ревизией файлах было бы дублирование методовsetMarkdownSanitizerConfig/setMarkdownRendererOptionsme_custom.mp4