Add basic UI #5
Add basic UI #5
Conversation
|
IMPORTANT |
There was a problem hiding this comment.
STATUS: REQUIRES CHANGES ♻️
Hi @Mehdi-Rh 👋,
Good job so far!
There are some issues that you still need to work on to go to the next project but you are almost there!
Highlights 🎯
✔️ Descriptive PR
✔️ No linter errors
✔️ Used correct GitFlow
Required Changes ♻️
Check the comments under the review.
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
You can also consider:
- n/a
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
| def initialize(age, name = 'Unknown', parent_permission = true) | ||
| # rubocop:enable Style/OptionalBooleanParameter |
There was a problem hiding this comment.
- There is a bug 🐛 when I attempt to create a teacher person as shown below 👇. Please try to fix it 👍
| def add_rental | ||
| puts 'Choose a person: ' | ||
| @people_list.each { |person| puts "#{person.id} : #{person.name}" } | ||
| person_id = gets.chomp.to_i | ||
|
|
||
| person = @people_list.select { |item| item.id == person_id } | ||
|
|
||
| puts 'Choose a book: ' | ||
| @book_list.each { |book| puts "#{book.id} : #{book.title}" } | ||
| book_id = gets.chomp.to_i | ||
|
|
||
| book = @book_list.select { |item| item.id == book_id } | ||
|
|
There was a problem hiding this comment.
-
When creating a rental, the person should be selected by number and not by their ID
-
The book should be selected by number and not by ID
-
There's a bug 🐛 while creating a rental as shown below. Please fix it 🙏
There was a problem hiding this comment.
Bro, there is no time and no energy to fix those issues !!
There was a problem hiding this comment.
I understand that this could be draining, please don't give up. You'll get there 👍
There was a problem hiding this comment.
I have only 5 minutes to submit the project, otherwise I'll repeat the week
There was a problem hiding this comment.
Hi @Mehdi-Rh,
Great work on making the changes requested by a previous reviewer 👏
You've done well implementing some of the requested changes, but there are still some which aren't addressed yet.
Highlights
✔️ Descriptive Readme
✔️ Passing Linters
✔️ Correct Gitflow
Required Changes ♻️
Check the comments under the review.
- The requested changes by the previous reviewer have not been implemented, kindly do so.
Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
Description
In this PR, I created a form of UI for the school library app. This way it can be invoked as an executable and not something you use in IRB exclusively.
Getting started
ruby main.rb