HA priority feature #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ch3n60x
force-pushed
the
ha_priority
branch
5 times, most recently
from
7c1cf63
to
0b046f3
Compare
Before this commit, when we restore VFs, it will be in the order of how we init the VFs. However, during HA recovery, QEMU could send vhost-user messages for different purpose to specific VF. It's better to let those VF recover first. So in this commit, we add a VF priority mechaism based on current HA recovery and vhost-user messages could trigger HA service to add priority VFs. Signed-off-by: Chenbo Xia <chenbox@nvidia.com>
We already have priority mechanism for vhost-user messages, so we also should have that for RPC commands. When specific RPC command comes, we should raise the priority for VFs to restore first. Signed-off-by: Chenbo Xia <chenbox@nvidia.com>
Field 'configured' is not set in virtio_vdpa_dev_vf_filter_dump(), which leads to rpc command of list VF info will always show VF is not configured. This commit fixes this issue. Signed-off-by: Chenbo Xia <chenbox@nvidia.com>
This commit adds below information in RPC 'version' call: 1. Build time information of vfe-vdpa. 2. Version and build time information of virtio-ha. Signed-off-by: Chenbo Xia <chenbox@nvidia.com>
kailiangz1
reviewed
Apr 23, 2024
| if (ret < 0) | ||
| rte_exit(EXIT_FAILURE, "ha client dev restore failed\n"); | ||
| rte_exit(EXIT_FAILURE, "ha client dev restore pf failed\n"); | ||
|
|
||
| ret = vdpa_rpc_start(&vdpa_rpc_ctx); |
There was a problem hiding this comment.
rpc start after restore, why we can receive RPC msg when restore?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for adding VF restore priority for vhost-user messages and rpc commands.