version 3.0.2 #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Briskin <abriskin@nvidia.com>
* Refactor TX preconditions to separate functions * Decouple precondition testing from side-effects such as flag setting * Move outside the critical section non-critical operations * Remove unnecessary goto statements and labels * Replace imperative calculations with standard algorithm inside loops Signed-off-by: Alex Briskin <abriskin@nvidia.com>
1. Move xlio_ti to qp_mgr.h 2. Change xlio_send_attr from typedef to struct name 3. Add const/noexcept method attributes 4. Remove unused attr union from xlio_tx_call_attr_t Signed-off-by: Alex Briskin <abriskin@nvidia.com>
tcp_split_rexmit function used to split tcp segments by taking the pbuf chain of the orig segment and split it so the head pbuf will remain in the orig segment, and the second pbuf + its chain will be part of a new segment. The split was done incorrectly so the second pbuf had a wrong tot_len value. It wokred fine if the second pbuf has no chained pbufs. Signed-off-by: Iftah Levi <iftahl@nvidia.com>
* Move the nvme tests to nvme/nvme.cc
* Move the nvme ops to sockinfo_nvme.{h,cpp}
* Put the input processing logic in nvme_parse_input_args.cpp
* Refactor TX preconditions to separate functions
* Decouple precondition testing from side-effects such as flag setting
* Move outside the critical section non-critical operations
* Remove unnecessary goto statements and labels
* Replace imperative calculations with standard algorithm
inside loops
Signed-off-by: Alex Briskin <abriskin@nvidia.com>
Signed-off-by: Alex Briskin <abriskin@nvidia.com>
Signed-off-by: Alex Briskin <abriskin@nvidia.com>
Signed-off-by: Alex Briskin <abriskin@nvidia.com>
- Add const to get_lkey signature - iovec_veiw => pdu - nvme_pdu_mdesc = NVMEoTCP_TX::pdu + mem_desc - Update unit tests Signed-off-by: Alex Briskin <abriskin@nvidia.com>
- Update tests - Fix setsockopt Signed-off-by: Alex Briskin <abriskin@nvidia.com>
- Add dependency injection for send_segment and send_pdu functions - Implement segmentation of PDUs Signed-off-by: Alex Briskin <abriskin@nvidia.com>
Signed-off-by: Alex Briskin <abriskin@nvidia.com>
Signed-off-by: Alex Briskin <abriskin@nvidia.com>
Signed-off-by: Alex Briskin <abriskin@nvidia.com>
Signed-off-by: Alex Briskin <abriskin@nvidia.com>
Signed-off-by: Alex Briskin <abriskin@nvidia.com>
Signed-off-by: Alex Briskin <abriskin@nvidia.com>
Signed-off-by: Alex Briskin <abriskin@nvidia.com>
Signed-off-by: Alex Briskin <abriskin@nvidia.com>
Signed-off-by: Alex Briskin <abriskin@nvidia.com>
Signed-off-by: Alex Briskin <abriskin@nvidia.com>
Signed-off-by: Alex Briskin <abriskin@nvidia.com>
Signed-off-by: Alex Briskin <abriskin@nvidia.com>
Signed-off-by: Alex Briskin <abriskin@nvidia.com>
Signed-off-by: Alex Briskin <abriskin@nvidia.com>
Signed-off-by: Alex Briskin <abriskin@nvidia.com>
Signed-off-by: Alex Briskin <abriskin@nvidia.com>
Signed-off-by: Alex Briskin <abriskin@nvidia.com>
Signed-off-by: Alex Briskin <abriskin@nvidia.com>
Signed-off-by: Alex Briskin <abriskin@nvidia.com>
Signed-off-by: Alex Briskin <abriskin@nvidia.com>
Signed-off-by: Alex Briskin <abriskin@nvidia.com>
Signed-off-by: Alexander Grissik <agrissik@nvidia.com>
Signed-off-by: Igor Ivanov <igori@nvidia.com>
Signed-off-by: Alex Briskin <abriskin@nvidia.com>
Call single tcp_tx inside nvme_ops::tx. Refactor nvme_ops to *only* receive complete NVMe PDUs. Signed-off-by: Alex Briskin <abriskin@nvidia.com>
Signed-off-by: Alex Briskin <abriskin@nvidia.com>
Signed-off-by: Alex Briskin <abriskin@nvidia.com>
Signed-off-by: Alex Briskin <abriskin@nvidia.com>
…::attr Signed-off-by: Alex Briskin <abriskin@nvidia.com>
Signed-off-by: Alexander Grissik <agrissik@nvidia.com>
Controlled by XLIO_SKIP_POLL_IN_RX: SKIP_POLL_IN_RX_DISABLE = 0 SKIP_POLL_IN_RX_ENABLE = 1 SKIP_POLL_IN_RX_EPOLL_ONLY = 2 By default, TCP sockets will poll CQ in Rx (SKIP_POLL_IN_RX_DISABLE). In case of SKIP_POLL_IN_RX_ENABLE - All TCP sockets will skip CQ poll. In case of SKIP_POLL_IN_RX_EPOLL_ONLY - Only sockets that were added to epoll will skip CQ polling. Signed-off-by: Iftah Levi <iftahl@nvidia.com>
To allow GRO + flow tag. Controlled by XLIO_DISABLE_FLOW_TAG. Default value is 0 (flow tag enabled). Signed-off-by: Iftah Levi <iftahl@nvidia.com>
Signed-off-by: Alexander Grissik <agrissik@nvidia.com>
Signed-off-by: Alexander Grissik <agrissik@nvidia.com>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.