Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: post process openapi schema to allow null types #214

Merged
merged 4 commits into from
Sep 11, 2023
Merged

fix: post process openapi schema to allow null types #214

merged 4 commits into from
Sep 11, 2023

Conversation

mjsqu
Copy link
Contributor

@mjsqu mjsqu commented Sep 11, 2023

May resolve #212

Post-processes the schema returned from the tap_dbt.client.OPENAPI_URL to extend types to e.g.:

["string","null"]

When a schema has a property with:

"nullable": true

Local testing completed OK.

@mjsqu mjsqu changed the title Post process openapi schema to allow null types Fix: post process openapi schema to allow null types Sep 11, 2023
@sonarcloud
Copy link

sonarcloud bot commented Sep 11, 2023

Please retry analysis of this Pull-Request directly on SonarCloud.

@mjsqu mjsqu changed the title Fix: post process openapi schema to allow null types fix: post process openapi schema to allow null types Sep 11, 2023
edgarrmondragon
edgarrmondragon approved these changes Sep 11, 2023
View reviewed changes
Copy link
Member

@edgarrmondragon edgarrmondragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks @mjsqu!

@edgarrmondragon edgarrmondragon merged commit 00e29e7 into MeltanoLabs:main Sep 11, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edgarrmondragon edgarrmondragon edgarrmondragon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Declare more fields as nullable
2 participants
@mjsqu @edgarrmondragon