Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add scraping functions and dependentsStream for repositories #127

Merged
merged 18 commits into from
May 23, 2022
Merged

Add scraping functions and dependentsStream for repositories #127

merged 18 commits into from
May 23, 2022

Conversation

ericboucher
Copy link
Contributor

Add scraping functions and add dependentsStream for repositories.

@ericboucher ericboucher changed the title Add scraping functions and add dependentsStream for repositories Add scraping functions and dependentsStream for repositories May 19, 2022
laurentS
laurentS requested changes May 19, 2022
View reviewed changes
Copy link
Contributor

@laurentS laurentS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is cool :)
Just one question: what are the rate limits that apply to scraping github web?

tap_github/repository_streams.py Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
tap_github/scraping.py Outdated Show resolved Hide resolved
tap_github/scraping.py Outdated Show resolved Hide resolved
tap_github/scraping.py Outdated Show resolved Hide resolved
tap_github/scraping.py Outdated Show resolved Hide resolved
tap_github/scraping.py Outdated Show resolved Hide resolved
tap_github/scraping.py Outdated Show resolved Hide resolved
tap_github/scraping.py Outdated Show resolved Hide resolved
Base automatically changed from stargazers-graphql to main May 19, 2022 22:57
@sonarcloud
Copy link

sonarcloud bot commented May 23, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ericboucher ericboucher mentioned this pull request May 23, 2022
Closed
@ericboucher ericboucher merged commit f330972 into main May 23, 2022
@ericboucher ericboucher deleted the dependents-stream branch May 23, 2022 18:50
@ericboucher ericboucher linked an issue May 29, 2022 that may be closed by this pull request
Add dependents field on repositories stream #34
Closed
@ericboucher ericboucher mentioned this pull request May 29, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laurentS laurentS laurentS approved these changes

@edgarrmondragon edgarrmondragon Awaiting requested review from edgarrmondragon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add dependents field on repositories stream
2 participants
@ericboucher @laurentS